Engineering

Review pull requests

Reads each new pull request and leaves notes before a person does.

Code review

Code reviewReads each new pull request and leaves notes before a person does.

Message Code review

Start it with

What it did

What waited for you

Nothing. It only read, worked and reported, so it needed no OK.

Use this DaeA sample chat. Names and numbers are made up.

Read the whole chat

You
Read new pull requests in northbeam/web. Check for missing tests and risky queries. Comment only on real problems.
Listed pull requests · GitHub · 3 open
Read diff · GitHub · #924 report filters
Reviews
- northbeam/web
- Open: 3
- Real problems: 1
- #924 Report filters, Query built from filter text: reports/query.ts:41: Priyanka, +212 −40 · 1 problem · button: Comment
- #925 Saved view icons, : Jo, +38 −12 · Looks fine
- #926 Bump date-fns, Tests pass: dependabot, +4 −4 · Looks fine
Code review
One real problem. #924 builds a query from the filter text, so a quote in a filter breaks the report (line 41). The other two look fine.